Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file uploads and downloads #804

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Add file uploads and downloads #804

merged 4 commits into from
Sep 26, 2024

Conversation

nicolexxuu
Copy link
Contributor

@nicolexxuu nicolexxuu commented May 11, 2024 •
edited by lowtorola
Loading

Closes #792

Update: Closes #806, #823 🚀

lowtorola
lowtorola requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolexxuu Lmk if this review helps!

frontend2/src/views/Account.tsx Outdated Show resolved Hide resolved
frontend2/src/views/Account.tsx Outdated Show resolved Hide resolved
@nicolexxuu nicolexxuu marked this pull request as ready for review July 4, 2024 16:34
@nicolexxuu
Copy link
Contributor Author

should I implement avatar file downloads as well?
also npm run lint still doesn't work for me ☹️

@nicolexxuu nicolexxuu requested a review from lowtorola July 4, 2024 18:48
lowtorola
lowtorola requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice job! I would say we don't really need avatar downloads tbh. Don't worry about lint, I can run it locally once your PR is all set to go. Just added a few tiny comments then we can :shipit:

frontend2/src/components/tables/submissions/SubHistoryTable.tsx Outdated Show resolved Hide resolved
frontend2/src/components/tables/submissions/SubHistoryTable.tsx Outdated Show resolved Hide resolved
frontend2/src/components/tables/submissions/SubHistoryTable.tsx Outdated Show resolved Hide resolved
frontend2/src/views/Account.tsx Outdated Show resolved Hide resolved
frontend2/src/api/compete/useCompete.ts Outdated Show resolved Hide resolved
@lowtorola lowtorola linked an issue Sep 25, 2024 that may be closed by this pull request
Other Team Link Broken #823
Closed
@lowtorola lowtorola changed the title Add file downloads Add file uploads and downloads Sep 25, 2024
@lowtorola lowtorola force-pushed the nicole/file-downloads branch 2 times, most recently from 5dd411c to 17399ca Compare September 25, 2024 21:10
lowtorola
lowtorola approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@lowtorola lowtorola merged commit 5fbf752 into main Sep 26, 2024
3 checks passed
@lowtorola lowtorola deleted the nicole/file-downloads branch September 26, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowtorola lowtorola lowtorola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Other Team Link Broken Team Avatar Upload Add file downloads
2 participants
@nicolexxuu @lowtorola